Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #244

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Cleanup #244

wants to merge 6 commits into from

Conversation

iciclejj
Copy link
Collaborator

@iciclejj iciclejj commented Feb 7, 2025

No description provided.

@iciclejj iciclejj marked this pull request as ready for review February 7, 2025 16:03
@iciclejj iciclejj requested a review from Yoonsen February 7, 2025 16:21
@iciclejj
Copy link
Collaborator Author

iciclejj commented Feb 7, 2025

Ang. 305b7a7 ser ut som at .corpus alltid er initialisert, mens .frame bare er laget når man konstruerer Corpuset fra en DataFrame med from_df etc. Kunne du bekrefte at dette er riktig?

Lurer også på om den med vilje er lagret separat fra .corpus, eller om jeg heller skal endre Corpus til å lagre DataFramen til enten .corpus eller .frame i begge tilfeller og fullstendig droppe den andre. @Yoonsen

Some files had DOS (CR/LF) line-endings
Removed redundant code
Refactored for clarity (don't hide dhlabid verification function call inside the URN verification function)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant