Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLT-0045 Add Hostname on Order IDs for SynQ Orders #49

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

anotheroneofthese
Copy link
Collaborator

Prevents order conflicts with multiple hosts.

Remains a draft we decide where it is best to handle the validation for this (likely domain, or should it happen in the service?).

@anotheroneofthese anotheroneofthese changed the title MLT-0045 Add Order IDs to SynQ Orders MLT-0045 Add Hostname on Order IDs for SynQ Orders Nov 4, 2024
Copy link
Collaborator

@MormonJesus69420 MormonJesus69420 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, have we made a task to migrate the order logic from SynQ Controler to Order domain logic?

@anotheroneofthese anotheroneofthese marked this pull request as ready for review November 5, 2024 07:54
@anotheroneofthese anotheroneofthese merged commit bc06345 into main Nov 5, 2024
5 checks passed
@anotheroneofthese anotheroneofthese deleted the mlt-0045-better-order-ids branch December 18, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants