Add FNC1 (and GS1) support #97
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmtx/libdmtx#10 Simply pushing \x1d will result in ASCII RS codeword (030) instead of actual FNC1 codeword (232), this commit allows GS1 encoding. `fnc1=29` can be used to substitute \x1d
alexis-via
approved these changes
Oct 18, 2024
Tested, doesn't work for FNC1. Adding anything to 'fnc=' won't make scanners find FNC1 injection in dmtx |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support FNC1 char function in libdmtx: dmtx/libdmtx#10
Simply pushing
\x1dcurrently results in ASCII RS codeword (030) instead of actual FNC1 codeword (232), this commit fixes that.As opposed to #96 FNC1 is not prepended by default since it can be used on non-GS1 barcodes, and substitution char is customizable like in the original libdmtx commit.
(
fnc1=29can be used to substitute\x1d)