Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for push constants in GLSL #59

Merged
merged 3 commits into from
Jan 21, 2025
Merged

Conversation

SirLynix
Copy link
Contributor

No description provided.

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 69.89247% with 28 lines in your changes missing coverage. Please review.

Project coverage is 76.76%. Comparing base (7b97ce7) to head (8f9c124).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/CNZSL/GlslWriter.cpp 0.00% 16 Missing ⚠️
src/NZSL/GlslWriter.cpp 76.47% 8 Missing ⚠️
src/ShaderCompiler/Compiler.cpp 86.66% 0 Missing and 2 partials ⚠️
tests/src/Tests/ToolUtils.cpp 90.90% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   76.57%   76.76%   +0.19%     
==========================================
  Files         158      158              
  Lines       21636    21661      +25     
  Branches     6405     6709     +304     
==========================================
+ Hits        16567    16628      +61     
+ Misses       4973     4940      -33     
+ Partials       96       93       -3     
Files with missing lines Coverage Δ
include/NZSL/GlslWriter.hpp 100.00% <ø> (ø)
include/NZSL/GlslWriter.inl 100.00% <ø> (+12.50%) ⬆️
...t/ConstantPropagationVisitor_BinaryArithmetics.cpp 83.90% <100.00%> (ø)
src/ShaderCompiler/Compiler.hpp 100.00% <ø> (ø)
tests/src/Tests/DebugInfoTests.cpp 100.00% <ø> (ø)
tests/src/Tests/ExternalTests.cpp 100.00% <ø> (ø)
tests/src/Tests/FilesystemResolverTests.cpp 100.00% <ø> (ø)
tests/src/Tests/NzslcTests.cpp 100.00% <100.00%> (ø)
tests/src/Tests/ShaderUtils.cpp 75.00% <100.00%> (+0.25%) ⬆️
src/ShaderCompiler/Compiler.cpp 52.26% <86.66%> (+6.85%) ⬆️
... and 3 more

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b97ce7...8f9c124. Read the comment docs.

@SirLynix SirLynix merged commit a39f15f into main Jan 21, 2025
92 checks passed
@SirLynix SirLynix deleted the glsl_push_constants branch January 21, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant