Changes in words and definitions handler, updated readme #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finding words didn't work for me, result was always empty, so no records were added to database, and apkg were created without definition. To overcome it I've changed faulty jquery (I suppose) to separating words with substring, which searches for closing tag of h2 (opening tag was the most suitable for separator for my dictionary, as it was before every word, after the word comes the closing tag), and then assigning substring before closing tag to word, and the rest after the closing tag to the definition. This way query now works like a charm, but it might not work for every dictionary, as layout might differ, so further research is required.
yinchyy
commented
Apr 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.