Kd/91 remove insecure debug endpoints #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevindeforth
force-pushed
the
kd/91-remove-insecure-debug-endpoints
branch
2 times, most recently
from
437caa1 to
e9a2fca
Compare
- /debug/tasks, /debug/index and /debug/sign are only compiled in test mode
kevindeforth
force-pushed
the
kd/91-remove-insecure-debug-endpoints
branch
from
3ef3a9f to
1a5796f
Compare
bowenwang1996
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Looks good. @robin-near do you want to expose debug_tasks in some way?
|
I was thinking of debug_tasks... but I don't have a good solution here short of exposing two ports which is a bit overkill. Let's just go with this for now. Later maybe we can put /debug/tasks behind a feature flag. |
robin-near
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #91
Isolated the debugging endpoint logic into a different file.
I am new to rust, probably not the best way of doing this. Feedback appreciated.