fix: restart ws connection to rpc when it was dropped and sync lost blocks #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frolvanya
commented
Feb 4, 2025
|
|
||
| error!("{chain_kind:?} WebSocket stream closed unexpectedly, reconnecting..."); | ||
| start_block = None; |
There was a problem hiding this comment.
This is done to make sure that first start uses start_block (if it was provided as an argument) and then we need to switch back to using last_processed_block. Let me know if this should be refactored using better code practices
Also, same logic can be found in solana startup files
There was a problem hiding this comment.
Usually, it is done in this way:
let mut last_processed_block = start_block.unwrap_or(redis.get_last_processed_block());
loop {
lake::start(last_processed_block, &mut last_processed_block)
}
But you implementation is ok for now
karim-en
approved these changes
Feb 7, 2025
|
|
||
| error!("{chain_kind:?} WebSocket stream closed unexpectedly, reconnecting..."); | ||
| start_block = None; |
There was a problem hiding this comment.
Usually, it is done in this way:
let mut last_processed_block = start_block.unwrap_or(redis.get_last_processed_block());
loop {
lake::start(last_processed_block, &mut last_processed_block)
}
But you implementation is ok for now
frolvanya
added a commit
that referenced
this pull request
Feb 7, 2025
frolvanya
added a commit
that referenced
this pull request
Feb 7, 2025
* feat: added message field for solana transfers * feat: provided more context in logs (#225) * feat: provided more context in logs * chore: updated omni-types * chore: retry if attached deposit is too low * chore: remove event if signature verification failed * chore: added release relayer (#226) * chore: added release relayer * chore: try to adjust repo url * chore: change workdir * chore: rename * chore: bring back correct yml * chore: update contracts tag trigger * chore: moved dist to correct place * fix: deleted musl target * fix: restart ws connection to rpc when it was dropped and sync lost blocks (#227)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found an issue when connection can be dropped right when new event should be found, so we need to fetch everything from the last_processed_block
