feat: Allow server side configuration of pubsub #26
+94
−47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very important to make this image useful, especially when using in ephemeral testing environments using tools like garden.io please do merge this as soon as possible. Thank you. |
|
@NeoScript @AlbertoMonteiro any chance we could merge this? |
|
It would be great to merge this. We need to be able to specify FYI @NeoScript 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow external configuration to be provided to configure URL of the pubsub emulator.
Needs to be provided as an environment variable in the docker container "PUBSUB_EMULATOR_HOST"
Should solve this issue #25