Limit resize notifications #31
Conversation
cosmoz-tabbable-behavior.html
Outdated
| }, | ||
|
|
||
| _onDescendantIronResize(event) { | ||
| if (this._notifyingDescendant || !this.isVisible) { |
There was a problem hiding this comment.
Shouldn't it be this._isVisible ?
cosmoz-tabbable-behavior.html
Outdated
| } | ||
| }); | ||
|
|
||
| if (!this.isVisible) { |
|
@plequang Fixed typos. |
Prevent firing resize upwards from a descendent when it is not a tab or cosmoz-tabs is not visible Resize
megheaiulian
force-pushed
the
feature/NEO-39-resizable
branch
from
8d29935 to
a6a4de3
Compare
cosmoz-tabbable-behavior.html
Outdated
| return Boolean(this.offsetWidth || this.offsetHeight); | ||
| }, | ||
|
|
||
| _onDescendantIronResize(event) { |
There was a problem hiding this comment.
Redefining _onDescendantIronResize in tabbable behavior is a bit confusing.
Because, looking at cosmoz-tab behaviors:
behaviors: [
Cosmoz.TabbableBehavior,
Cosmoz.TabbedBehavior
],
one might think this overridden method will also apply to cosmoz-tab, which is not the case (because the last behavior takes precedence).
So because tabbable behavior is shared between cosmoz-tabs and cosmoz-tab, it would be much clearer if _onDescendantIronResize was redefined in cosmoz-tabs.
cosmoz-tabbable-behavior.html
Outdated
| } | ||
| }); | ||
|
|
||
| if (!this._isVisible) { |
There was a problem hiding this comment.
Wouldn't it be also possible to not notify descendants when this._isVisible is false ?
cosmoz-tabbable-behavior.html
Outdated
| return; | ||
| } | ||
|
|
||
| if (!Polymer.Settings.useShadow) { |
There was a problem hiding this comment.
If redefining _onDescendantIronResize, maybe you should consider this PR PolymerElements/iron-resizable-behavior#35
Limit resize notifications to selected tab and check for visible before firing a resize.
fixes #30