Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump all dependencies #233

Closed
wants to merge 1 commit into from
Closed

Conversation

Sword-Smith
Copy link
Member

Bumps all dependencies to latest version, or newer.

@coveralls
Copy link

coveralls commented Sep 30, 2024

Coverage Status

coverage: 97.767% (+0.1%) from 97.65%
when pulling bdc468d on bump-dependencies
into cf38e3a on master.

Copy link
Member

@jan-ferdinand jan-ferdinand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not opposing this change, since “just use the latest” has been our approach to dependencies for a long time now. However, given that you're asking for my review right now, the recommendation given in “Rust for Rustaceans”1 is:

The right strategy is to list the earliest version that has all the things your crate depends on […].

The subsection also contains the explanation why this is the right strategy, how to accomplish it, and how to enforce it in CI.2

Footnotes

  1. Chapter 5, Section “Versioning”, Subsection “Minimal Dependency Versions”, emphasis mine

  2. I don't want to paste the entire section on the public internet but am happy to lend you the book should you be interested.

@Sword-Smith
Copy link
Member Author

Thanks for the insight. As @jan-ferdinand explained, the reason not to bump versions if stuff works is that it'll be harder for other crates to share dependencies with this.

@Sword-Smith Sword-Smith closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants