This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Fix cmake #39
Open
Fix cmake #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kbinias
reviewed
Dec 19, 2019
CMakeLists.txt
Outdated
| if (${CMAKE_VERSION} VERSION_LESS "3.13.3") | ||
| find_package(PythonInterp) | ||
| set(Python_Interpreter_FOUND ${PYTHONINTERP_FOUND}) | ||
| set(Python_EXECUTABLE ${Python_EXECUTABLE}) |
There was a problem hiding this comment.
Assignment is not required in this case or you mean PYTHON_EXECUTABLE
There was a problem hiding this comment.
Thanks, it was supposed to be all uppercase.
CMakeLists.txt
Outdated
|
|
||
| if (PYTHON_PLUGIN) | ||
| if (NOT ${PYTHON_VERISON_MAJOR} EQUAL ${OpenCV_VERSION_MAJOR}) | ||
| message(WARNING "Python version " ${PYTHON_VERSION_MAJOR} " incompatible with OpenCV version " ${OpenCV_VERSION_MAJOR}) | ||
| if (${Python_VERISON_MAJOR} LESS ${OpenCV_VERSION_MAJOR}) |
There was a problem hiding this comment.
Typo in Python_VERISON_MAJOR, should be Python_VERSION_MAJOR
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping cmake version to 3.13.3 allows usage of
find_package(Python COMPONENTS Interpreter Development NumPy)which is superior to previous methods. Eliminates need for additional FindNumpy module and solves problem of python version 2/3 mismatch.It should work theoretically, but it finds python2.6 over 3.4 on my docker so I don't have successful proof.
Sources: https://cmake.org/cmake/help/v3.13/module/FindPython.html