dawehner/amp-library #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tom script tags from: https://github.com/ampproject/amphtml/blob/master/extensions/amp-ad/0.1/validator-amp-ad.protoascii Regenerating the validator was necessary to avoid flagging the script tag for <amp-ad> in <head> as an error
removed duplicate word "output"
Add img_max_fixed_layout_width option
Add amp-ad script to <head> if needed
Support Facebook posts with photo url schemas
Bug fix: height check on setResponsiveImgHeightAndWidth
Fix for the Youtube code getter
Update README.md
Add amp-sidebar component mapping on context.php
The DOM parser throws away invalid HTML. When you have http://youtube.com/embed/_FlV6pgwlrk&list=123 then the `IframeYouTubeTagTransformPass::getYouTubeCode()` will match the ID as `_FlV6pgwlrk&list=123` but since the ampersand isn't in a proper HTML format (`&`), then DOM will throw this whole element away. I wrote a test to make sure noone breaks this in the future.
Migrating multiple fixes upstream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lullabot#162