Skip to content

Commit

Permalink
ci: detect poller logs errors (#2603)
Browse files Browse the repository at this point in the history
doc: add missing RBAC permissions to docs
  • Loading branch information
cgrinds authored Jan 25, 2024
1 parent 8184341 commit 9076ffb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
2 changes: 2 additions & 0 deletions docs/prepare-cdot-clusters.md
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,7 @@ Warnings are fine.

```bash
security login role create -role harvest2-role -access readonly -cmddirname "cluster"
security login role create -role harvest2-role -access readonly -cmddirname "event notification destination show"
security login role create -role harvest2-role -access readonly -cmddirname "lun"
security login role create -role harvest2-role -access readonly -cmddirname "metrocluster configuration-settings mediator add"
security login role create -role harvest2-role -access readonly -cmddirname "network interface"
Expand All @@ -105,6 +106,7 @@ security login role create -role harvest2-role -access readonly -cmddirname "sto
security login role create -role harvest2-role -access readonly -cmddirname "storage encryption disk"
security login role create -role harvest2-role -access readonly -cmddirname "storage iscsi-initiator show"
security login role create -role harvest2-role -access readonly -cmddirname "storage shelf"
security login role create -role harvest2-role -access readonly -cmddirname "system health alert show"
security login role create -role harvest2-role -access readonly -cmddirname "system health status show"
security login role create -role harvest2-role -access readonly -cmddirname "system health subsystem show"
security login role create -role harvest2-role -access readonly -cmddirname "system node"
Expand Down
3 changes: 2 additions & 1 deletion integration/test/copy_logs_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ func TestNoErrors(t *testing.T) {
}

func checkLogs(t *testing.T, container docker.Container) {
cli := fmt.Sprintf(`docker logs %s 2>&1 | grep -v "%s" | grep -E "ERR"`, container.ID, ignoreList())
cli := fmt.Sprintf(`docker logs %s 2>&1 | grep -v '%s' | grep -E "ERR"`, container.ID, ignoreList())
command := exec.Command("bash", "-c", cli)
output, err := command.CombinedOutput()
// The grep checks for matching lines.
Expand Down Expand Up @@ -71,6 +71,7 @@ func checkLogs(t *testing.T, container docker.Container) {
}

// ignoreList returns a list of errors that should be ignored
// Only use double quotes (") to group messages, not single quotes
func ignoreList() any {
return `RPC: Remote system error|"connection error"`
}

0 comments on commit 9076ffb

Please sign in to comment.