Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct c++ version on OSX for Node.js 20+ #32

Merged
merged 2 commits into from
Aug 15, 2023
Merged

fix: use correct c++ version on OSX for Node.js 20+ #32

merged 2 commits into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. chore: test against Node.js 20 on OSX

    @mmarchini
    mmarchini committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    0178373 View commit details
    Browse the repository at this point in the history

  2. fix: use correct c++ version on OSX for Node.js 20+ 

    For some reason this is not an issue on Linux, so as to avoid a breaking
change, only use C++17 on OS X if the Node.js version is at least v20.
    @mmarchini
    mmarchini committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4afb3b5 View commit details
    Browse the repository at this point in the history