Merge pull request #151 from Netflix/jkoch/skip-cancel

perf: skip future cancellation when not needed
Netflix · Dec 6, 2024 · 9ddd6a9 · 9ddd6a9
2 parents d2f9c43 + b200a51
commit 9ddd6a9
Showing 1 changed file with 0 additions and 3 deletions.
diff --git a/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java b/evcache-core/src/main/java/com/netflix/evcache/EVCacheImpl.java
@@ -613,7 +613,6 @@ private <T> CompletableFuture<T> doAsyncGet(EVCacheKey evcKey, Transcoder<T> tc)
             if (log.isDebugEnabled() && shouldLog()) log.debug("Error while building and starting the event");
             return errorFuture;
         }
-        errorFuture.cancel(false);
 
         final long start = EVCacheMetricsFactory.getInstance().getRegistry().clock().wallTime();
         StringBuilder status = new StringBuilder(EVCacheMetricsFactory.SUCCESS);
@@ -2375,8 +2374,6 @@ private <T> CompletableFuture<Map<String, T>> doAsyncGetBulk(Collection<String>
             if (log.isDebugEnabled() && shouldLog()) log.debug("Error while building and starting the event for doAsyncGetBulk");
             return errorFuture;
         }
-        if (log.isDebugEnabled() && shouldLog()) log.debug("Cancelling the error future");
-        errorFuture.cancel(false);
 
         final long start = EVCacheMetricsFactory.getInstance().getRegistry().clock().wallTime();
         StringBuilder status = new StringBuilder(EVCacheMetricsFactory.SUCCESS);