This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Feature: Need for Task status listener #3623
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scheduled. Addresses below issues: Netflix#3587 Netflix#2020
charybr
pushed a commit
to charybr/conductor-community
that referenced
this pull request
May 24, 2023
Hi @charybr , thanks for the contribution.
thoughts @v1r3n @c4lm @apanicker-nflx ? |
Thanks very much Manan! for the response. Please find my comments inline.
This is correct, just like in the case of WorkStatusListener I am adding interface and stub in main repo. Implementation is in the form of Webhook module in conductor-community repo (there is a separate PR - Netflix/conductor-community#228)
Soon i will add other task status listener methods. |
implementation can choose to select interested statuses.
in TaskStatusListenerStub.
v1r3n
approved these changes
Jun 17, 2023
charybr
added a commit
to charybr/conductor-community
that referenced
this pull request
Jul 19, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
./gradlew generateLock saveLock
to refresh dependencies)NOTE: Please remember to run
./gradlew spotlessApply
to fix any format violations.Changes in this PR
Describe the new behavior from this PR, and why it's needed
Issue #3587
Need for Task status listener
When the status of a task changes, we need a mechanism to notify. Just like we have WorkflowStatusListener interface, we can have TaskStatusListener interface.
Alternatives considered
Describe alternative implementation you have considered