Return NoOp InstrumentationContext where possible #1590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srinivasankavitha
approved these changes
Aug 1, 2023
Change beginValidation to simply return the No-op InstrumentationContext if no document or QuerySignatureRepository are present. Additionally, only allocate tags in instrumentExecutionResult if there are actually errors, and avoid calling the get method on the registry supplier repeatedly. Finally, update DefaultMeterRegistrySupplier to avoid locking when calling the get method.
kilink
force-pushed
the
metrics-instrumentation-cleanup
branch
from
a0ef1eb to
68c1a02
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change beginValidation to simply return the No-op InstrumentationContext if no document or QuerySignatureRepository are present. Additionally, only allocate tags in instrumentExecutionResult if there are actually errors, and avoid calling the get method on the registry supplier repeatedly.
Finally, update DefaultMeterRegistrySupplier to avoid locking when calling the get method.