disabling more SSE tests #1721
Merged
disabling more SSE tests #1721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulbakker, I've noticed you've been disabling these tests but I'm not sure why they are valid tests and we don't want anything to break in them. If there is an issue, surely it's better to find out what caused them to be flakey rather than just disabling? |
|
We've been struggling with randomly hanging builds for a whil and have yet
to be able to pinpoint what's the problem. We have a hunch that the SSE
tests are having some race condition.
Once we confirm that disabling them fixes the problem we'll look into a
better solution.
…On Wed, Nov 22, 2023 at 12:55 PM Ancient-Dragon ***@***.***> wrote:
@paulbakker <https://github.com/paulbakker>, I've noticed you've been
disabling these tests but I'm not sure why they are valid tests and we
don't want anything to break in them. If there is an issue, surely it's
better to find out what caused them to be flakey rather than just disabling?
—
Reply to this email directly, view it on GitHub
<#1721 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA2XLHJLG4MYZXFHKWSQ63YFZRF3AVCNFSM6AAAAAA7VHJ5A6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRTGQ4TCNBUGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prevent stuck builds