Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): use local event to prevent slow down #5444

Merged
merged 2 commits into from
Nov 9, 2024
Merged

fix(ui): use local event to prevent slow down #5444

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
941396c
Use local event to prevent slow down
whitdog47 Nov 8, 2024
cfffe1f
Merge branch 'master' into bugfix/use-local-event
whitdog47 Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 19 additions & 8 deletions src/dispatch/static/dispatch/src/incident/EditEventDialog.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
<v-col cols="5">
<date-time-picker-menu
label="Reported At"
v-model="started_at"
v-model="local_started_at"
class="time-picker"
:timezone="timezone"
@update:model-value="update_started_at"
Expand Down Expand Up @@ -40,7 +40,7 @@
<v-row>
<v-col cols="12">
<v-textarea
v-model="description"
v-model="local_description"
class="mt-3"
label="Description"
hint="Description of the event."
Expand All @@ -54,10 +54,8 @@
<v-card-actions>
<v-spacer />
<v-btn variant="text" @click="closeEditEventDialog()"> Cancel </v-btn>
<v-btn v-if="uuid" color="green en-1" variant="text" @click="updateExistingEvent()">
OK
</v-btn>
<v-btn v-else color="green en-1" variant="text" @click="storeNewEvent()"> OK </v-btn>
<v-btn v-if="uuid" color="green en-1" variant="text" @click="updateEvent()"> OK </v-btn>
<v-btn v-else color="green en-1" variant="text" @click="newEvent()"> OK </v-btn>
</v-card-actions>
</v-card>
</v-dialog>
Expand All @@ -79,6 +77,8 @@ export default {
timezones: ["UTC", "America/Los_Angeles"],
timezone: "UTC",
started_at_in_utc: "",
local_started_at: null,
local_description: "",
}
},

Expand Down Expand Up @@ -112,13 +112,24 @@ export default {
this.eventStart = new Date()
},
update_started_at(val) {
this.started_at = val
this.local_started_at = val
this.started_at_in_utc = val
},
updateEvent() {
this.description = this.local_description
this.started_at = this.local_started_at
this.updateExistingEvent()
},
newEvent() {
this.description = this.local_description
this.started_at = this.local_started_at
this.storeNewEvent()
},
},
mounted() {
this.init()
this.started_at_in_utc = this.started_at
this.local_description = this.description
this.local_started_at = this.started_at
},
}
</script>
Expand Down
Loading