Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes option to delete a signal definition #5471

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

mvilanova
Copy link
Contributor

Summary of Changes

  1. Backend - service.py and views.py:

    • Removed the delete function in service.py, which previously handled deletion of signal definitions.
    • Deleted the delete_signal endpoint in views.py, including the associated permission check for deleting signals.
    • These changes eliminate the capability to delete signals from the backend.
  2. Frontend - Vue Components:

    • DeleteDialog.vue: Removed entirely. This file previously handled the delete confirmation dialog for signals.
    • Table.vue:
      • Removed <delete-dialog /> component reference from the template.
      • Deleted the delete action from the item menu, removing the "Delete" option for signals in the UI.
      • Updated components import to exclude DeleteDialog.

These modifications effectively remove the signal deletion functionality from both the backend and frontend.

@mvilanova mvilanova merged commit a557071 into master Nov 13, 2024
8 checks passed
@mvilanova mvilanova deleted the feat/removes-signal-definition-ui-delete-option branch November 13, 2024 23:40
mvilanova added a commit that referenced this pull request Nov 14, 2024
mvilanova added a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants