(contd.) fix: if the max ordinal for a map value is zero then reserve…

… 1 bit for it instead of nothing
Netflix · Dec 20, 2024 · 4e204c7 · 4e204c7
1 parent 2ba691b
commit 4e204c7
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/...rc/main/java/com/netflix/hollow/api/producer/validation/PrimaryKeyViolationValidator.java b/...rc/main/java/com/netflix/hollow/api/producer/validation/PrimaryKeyViolationValidator.java
@@ -0,0 +1,2 @@
+package com.netflix.hollow.api.producer.validation;public class PrimaryKeyViolationValidator {
+}
diff --git a/hollow/src/main/java/com/netflix/hollow/core/write/HollowMapTypeWriteState.java b/hollow/src/main/java/com/netflix/hollow/core/write/HollowMapTypeWriteState.java
@@ -185,7 +185,7 @@ private void calculateNumShards() {
         }
 
         long bitsPerKeyElement = 64 - Long.numberOfLeadingZeros(maxKeyOrdinal + 1);
-        long bitsPerValueElement = 64 - Long.numberOfLeadingZeros(maxValueOrdinal);
+        long bitsPerValueElement = maxValueOrdinal == 0 ? 1 : 64 - Long.numberOfLeadingZeros(maxValueOrdinal);
         long bitsPerMapSizeValue = 64 - Long.numberOfLeadingZeros(maxMapSize);
         long bitsPerMapPointer = 64 - Long.numberOfLeadingZeros(totalOfMapBuckets);
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		package com.netflix.hollow.api.producer.validation;public class PrimaryKeyViolationValidator {
		}