fix: removes memory leak (ref 'this') from HollowConsumerBuilder (#653)

Netflix · Dec 16, 2023 · 54a4d31 · 54a4d31
1 parent e7ce7db
commit 54a4d31
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/hollow/src/main/java/com/netflix/hollow/api/consumer/HollowConsumer.java b/hollow/src/main/java/com/netflix/hollow/api/consumer/HollowConsumer.java
@@ -1365,7 +1365,8 @@ protected void checkArguments() {
             }
 
             if (refreshExecutor == null) {
-                refreshExecutor = newSingleThreadExecutor(r -> daemonThread(r, getClass(), "refresh"));
+                final Class<?> clazz = getClass(); // to avoid capturing 'this' in lambda
+                refreshExecutor = newSingleThreadExecutor(r -> daemonThread(r, clazz, "refresh"));
             }
 
             if (!memoryMode.consumerSupported()) {