Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configurable scope parameter for OAuth2 #4520

Closed
wants to merge 2 commits into from
Closed

Configurable scope parameter for OAuth2 #4520

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5092c45
Configurable scope parameter for OAuth2
skorobkov78 Jul 22, 2023
d7e76d9
Merge branch 'main' into oauth2_scope_config
jmcrawford45 Oct 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lemur/auth/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -725,7 +725,7 @@ def get(self):
"redirectUri": current_app.config.get("OAUTH2_REDIRECT_URI"),
"clientId": current_app.config.get("OAUTH2_CLIENT_ID"),
"responseType": "code",
"scope": ["openid", "email", "profile", "groups"],
"scope": current_app.config.get("OAUTH2_SCOPE", ["openid", "email", "profile"]),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together. We'll want groups to stay in the default for backwards compatibility. Also, can we add an entry to docs/administration alongside the other oauth config options for this new option?

"scopeDelimiter": " ",
"authorizationEndpoint": current_app.config.get(
"OAUTH2_AUTH_ENDPOINT"
Expand Down
Loading