Skip to content

Commit

Permalink
Merge pull request #12 from Netflix/pass_through_query_params
Browse files Browse the repository at this point in the history
Pass through query params
  • Loading branch information
neerajrj authored Aug 4, 2020
2 parents 4abb26b + 209ba5c commit 764e193
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions src/main/java/io/mantisrx/api/push/ConnectionBroker.java
Original file line number Diff line number Diff line change
Expand Up @@ -285,19 +285,7 @@ private Observable<String> getWorkerMetrics(PushConnectionDetails details) {

final String jobId = details.target;

SinkParameters metricNamesFilter = new SinkParameters.Builder().build();
/*
try {
SinkParameters.Builder sinkParamsBuilder = new SinkParameters.Builder();
for (String metric : metricGroups) {
sinkParamsBuilder = sinkParamsBuilder.withParameter(METRIC_NAME_STR, metric);
}
metricNamesFilter = sinkParamsBuilder.build();
} catch (UnsupportedEncodingException e) {
log.error("error encoding sink parameters", e);
}
*/
SinkParameters metricNamesFilter = details.getSinkparameters();

final MetricsClient<MantisServerSentEvent> metricsClient = workerMetricsClient.getMetricsClientByJobId(jobId,
new SseWorkerConnectionFunction(true, new Action1<Throwable>() {
Expand Down

0 comments on commit 764e193

Please sign in to comment.