Add new IPC tags #1168
Open
Add new IPC tags #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umairk79
reviewed
Nov 12, 2024
spectator-ext-ipc/src/main/java/com/netflix/spectator/ipc/IpcMetric.java
Outdated
Show resolved
Hide resolved
added 2 commits
November 12, 2024 16:00
| /** | ||
| * Set the method used for this request. | ||
| */ | ||
| public IpcLogEntry withMethod(String method) { |
There was a problem hiding this comment.
Do we need both a string and enum version? That tends to work against consistency. As one example the enum uses lower case values for method, but if setting it with a string using some thing like request.getMethod() for some API it would often be upper cased. Ideally we would just have the enum and not allow arbitrary values.
| @@ -899,6 +925,7 @@ public String toString() { | |||
| .addField("protocol", protocol) | |||
| .addField("uri", uri) | |||
| .addField("path", path) | |||
| .addField("method", method) | |||
There was a problem hiding this comment.
Source and method should also get updated in reset() and perhaps populateMDC() so it will be available for logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new IPC tags as per the V2 spec:
Extended from #1155 with amendments.