Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins external library versions, other housekeeping #157

Merged
merged 1 commit into from
Feb 2, 2024
Merged

Conversation

klebba
Copy link
Collaborator

@klebba klebba commented Feb 2, 2024

Addresses #153

@klebba klebba requested a review from theengineear February 2, 2024 02:38
<uhtml-element message=" yay! "></uhtml-element>
<uhtml-element message=" woo! "></uhtml-element>
<ol>
<li><demo-uhtml message="one" emoji="🔥"></demo-uhtml></li>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

import { unsafeHTML } from 'https://unpkg.com/lit-html/directives/unsafe-html.js';
import { unsafeSVG } from 'https://unpkg.com/lit-html/directives/unsafe-svg.js';
import { until } from 'https://unpkg.com/lit-html/directives/until.js';
import { asyncAppend } from 'https://unpkg.com/[email protected]/directives/async-append.js';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@theengineear
Copy link
Collaborator

LGTM! Thanks for all the linguistic updates as well!

theengineear
theengineear previously approved these changes Feb 2, 2024
Copy link
Collaborator

@theengineear theengineear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klebba
Copy link
Collaborator Author

klebba commented Feb 2, 2024

Rebased

@klebba klebba self-assigned this Feb 2, 2024
Copy link
Collaborator

@theengineear theengineear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤘

@klebba klebba merged commit 67d2c1b into main Feb 2, 2024
1 check passed
@klebba klebba deleted the pin-unpkg-links branch February 2, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants