Update GitHub actions (versions / ergonomics). #172
Conversation
theengineear
force-pushed
the
update-actions
branch
2 times, most recently
from
89ba106 to
b44d9cc
Compare
| with: | ||
| node-version: '20.x' | ||
| registry-url: 'https://registry.npmjs.org' | ||
| - run: npm ci |
There was a problem hiding this comment.
In general — I’ve updated things to use clean install so that we install from package-lock.json for consistency.
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '20.x' |
There was a problem hiding this comment.
Node version is bumped to 20.x in all these configuration files.
| name: Publish | ||
| on: | ||
| release: | ||
| types: [published] |
There was a problem hiding this comment.
Updated the release type trigger to published as that appears to be the current recommendation.
theengineear
force-pushed
the
update-actions
branch
from
b44d9cc to
221fe94
Compare
| @@ -1,17 +1,16 @@ | |||
| name: Push | |||
| on: [push] | |||
| # Test flow triggered by other workflows. | |||
There was a problem hiding this comment.
Also, I’ve added a general change to pull out our workflows into reusable chunks. The GitHub UI sort of rewards you with a better UX for doing this (e.g., better graphical representation of what’s happening).
|
FYI @klebba — I’m just modernizing our GH actions stuff as we flesh out this ecosystem. I’m going to get this merged in and then will start testing the deployment flows. |
| on: | ||
| workflow_call: | ||
| inputs: | ||
| secrets: |
There was a problem hiding this comment.
Going to try and remove this — I believe that if we use secrets: inherit, you don’t need to explicitly declare inputs like that.
This change set bumps the referenced / reusable GitHub actions to their latest versions, bumps node versions, and enables reuse of a “test” wf.
theengineear
force-pushed
the
update-actions
branch
from
221fe94 to
223e308
Compare
| - uses: actions/checkout@v2 | ||
| - uses: actions/setup-node@v2 | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v3 |
There was a problem hiding this comment.
Bumped all these as part of the node 16 >> 20 upgrades in GH actions.
This change set bumps the referenced / reusable GitHub actions to their latest versions, bumps node versions, and enables reuse of a “test” wf.