Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix traffic by hour histogram #78

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cotosso
Copy link
Contributor

@cotosso cotosso commented Mar 4, 2025

fix out of order histograms dates when using "big" time periods (approx more then 15/30 days)

before:
image

after:
image

fix out of order histograms when using "big" time periods (approx more then 15/30 days)
@gsanchietti gsanchietti requested a review from Copilot March 5, 2025 07:46

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Copy link
Member

@gsanchietti gsanchietti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new query is wrong: remove the SUM call.
The error is quite evident inside the new chart.

@cotosso
Copy link
Contributor Author

cotosso commented Mar 5, 2025

Even using the original query (that has no SUM) and adding at the end this line to ensure the right chronological order:

+ ORDER BY bucket

the resulting graph is exactly the same, it still has this kind of "SUM" effect

image

@cotosso cotosso requested a review from gsanchietti March 5, 2025 09:38
@gsanchietti
Copy link
Member

So I guess the query is still wrong.
Please review the returned records.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants