Specify object types for group member management (#74)

* fix(add-group): specify object types when adding members to group * fix(group-management): specify object types when adding/removing members from group NethServer/dev#7286
NethServer · Feb 19, 2025 · 9881067 · 9881067
1 parent af65ff1
commit 9881067
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/imageroot/actions/add-group/50add_group b/imageroot/actions/add-group/50add_group
@@ -44,7 +44,7 @@ subprocess.run(addgroup_cmd, stdout=sys.stderr, check=True, text=True)
 if users:
     addmembers_cmd = [
         'podman', 'exec', 'samba-dc', 'samba-tool',
-        'group', 'addmembers', group, ','.join(users),
+        'group', 'addmembers', group, ','.join(users), '--object-types=user'
     ]
 
     subprocess.run(addmembers_cmd, stdout=sys.stderr, check=True, text=True)
diff --git a/imageroot/actions/alter-group/50alter_group b/imageroot/actions/alter-group/50alter_group
@@ -39,8 +39,8 @@ if 'users' in request:
 
     add_members = new_members - old_members
     if add_members:
-        subprocess.run(sambatool_cmd + ['group', "addmembers", group, ','.join(add_members)], stdout=sys.stderr, check=True, text=True)
+        subprocess.run(sambatool_cmd + ['group', "addmembers", group, ','.join(add_members), '--object-types=user'], stdout=sys.stderr, check=True, text=True)
 
     rem_members = old_members - new_members
     if rem_members:
-        subprocess.run(sambatool_cmd + ['group', "removemembers", group, ','.join(rem_members)], stdout=sys.stderr, check=True, text=True)
+        subprocess.run(sambatool_cmd + ['group', "removemembers", group, ','.join(rem_members), '--object-types=user'], stdout=sys.stderr, check=True, text=True)