Add scripts to manage Samba DC service based on domain change event #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a new configuration file, api-moduled-overwrite.conf, and removes the print-bound-domain-list command from the samba-dc.service file.
DavidePrincipi
requested changes
Jan 16, 2024
Comment on lines
23
to
26
| # Parse response['output'] and push to modules_set the name of each module | ||
| names_set=set() | ||
| for item in response['output']: | ||
| names_set.add(item.get('name')) |
There was a problem hiding this comment.
We are missing an important information from response['output']: the id field. A module instance has module_id == id + some numeric suffix. You should match it with id, not "name".
Examples of id, name retrieved from response['output']:
"grafana": "Grafana"
"webserver": "WebServer"
"mariadb": "MariaDB"
"nextcloud": "Nextcloud"
"mail": "Mail"
There was a problem hiding this comment.
Role definition and update must be moved to the core, to PR NethServer/ns8-core#545. This step can be removed.
Co-authored-by: Davide Principi <[email protected]>
Co-authored-by: Davide Principi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds two scripts: "write-user-portal-config" and "10reload_services" to manage the api-moduled.service based on a domain change event. The "write-user-portal-config" script write the bound domain list, while the "10reload_services" script
reloadsreconfigures the User portal frontend when a domain change event occurs.Refs