7591 abi encoding optimization

[ssonthal]

Fixes Closes Resolves #7591

Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.

Changes

• List the changes

Types of changes

What types of changes does your code introduce?

• Bugfix (a non-breaking change that fixes an issue)
• New feature (a non-breaking change that adds functionality)
• Breaking change (a change that causes existing functionality not to work as expected)
• Optimization
• Refactoring
• Documentation update
• Build-related changes
• Other: Description

Testing

Requires testing

• [] Yes
• No

If yes, did you write tests?

• Yes
• No

Documentation

Requires documentation update

• Yes
• No

If yes, link the PR to the docs update or the issue with the details labeled docs. Remove if not applicable.

Requires explanation in Release Notes

• Yes
• No

[ssonthal]

Hi @LukaszRozmej,

The understanding so far - NettyRlpStream uses ReadOnlySpan and dynamic memory allocation of IByteBuffer to efficiently allocate memory. So we either we can reuse that class in ABI encoding, or create a different class. I went with the second approach and created a rather duplicate called NettyAbiStream with same methods with slight differences (it doesn't inherit RlpStream so we can trim off some methods).

List of changes ->

1. Created NettyAbiStream that implements IDisposable interface (same as NettyRlpStream).
2. To confirm if the changes are in the right direction, for one of the AbiType -> AbiAddress, have tried using NettyAbiStream instead of previous byte[] allocation.

Please let me know your thoughts.

[ssonthal]

Please ignore this file. Will undo these changes once I have some confirmations from your end.

[ssonthal]

Hey @LukaszRozmej , awaiting your feedback on this.

[LukaszRozmej]

hard to say without example usages, the one for address doesn't do much

[LukaszRozmej]

you allocate both list and array, not achieving goal of removing allocations

[ssonthal]

I understand. Let me go over this again and get back.