refactor(repeater): stop sending ping #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bararchy
requested changes
Aug 12, 2024
denis-maiorov-brightsec
force-pushed
the
revert/heartbeat
branch
from
6441ae5
to
ccb20b4
Compare
denis-maiorov-brightsec
changed the title
bararchy
reviewed
Aug 12, 2024
bararchy
reviewed
Aug 12, 2024
bararchy
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping historically was there to signal over RMQ that repeater is still connected
Socket.IO implementation has built in mechanism for disconnection detection https://socket.io/docs/v4/engine-io-protocol/#heartbeat