Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): upgrade nx from 14.5.6 to 17.3.2 #208

Merged
merged 30 commits into from
Jul 11, 2024
Merged
Show file tree
Hide file tree
Changes from 29 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
67112ac
chore: [nx migration] 16.0.0-remove-nrwl-cli
pmstss Jul 10, 2024
1c5c164
chore: [nx migration] 16.0.0-update-nx-cloud-runner
pmstss Jul 10, 2024
b09054e
chore: [nx migration] 16.6.0-prefix-outputs
pmstss Jul 10, 2024
b4d5861
chore: [nx migration] 17.0.0-move-cache-directory
pmstss Jul 10, 2024
bf6fe3f
chore: [nx migration] 17.0.0-use-minimal-config-for-tasks-runner-options
pmstss Jul 10, 2024
201ee14
chore: [nx migration] rm-default-collection-npm-scope
pmstss Jul 10, 2024
12985e6
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
53189b2
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
a7d1768
chore: [nx migration] 16-0-0-move-workspace-generators-into-local-plugin
pmstss Jul 10, 2024
0c3801c
chore: [nx migration] 16-0-0-fix-invalid-babelrc
pmstss Jul 10, 2024
a4b251d
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
b13d294
chore: [nx migration] explicitly-set-projects-to-update-buildable-deps
pmstss Jul 10, 2024
3a5e133
chore: [nx migration] update-17-0-0-remove-deprecated-build-options
pmstss Jul 10, 2024
8dfe701
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
234e476
chore: [nx migration] update-17-0-0-rename-to-eslint
pmstss Jul 10, 2024
dcbfd1b
chore: [nx migration] simplify-eslint-patterns
pmstss Jul 10, 2024
aadf747
chore: [nx migration] move-options-to-target-defaults
pmstss Jul 10, 2024
db64737
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
8474b5e
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
48aac41
chore: [nx migration] move-options-to-target-defaults
pmstss Jul 10, 2024
4ea3850
chore: [nx migration] update-16-0-0-add-nx-packages
pmstss Jul 10, 2024
974fbaf
chore: remove deprecated `suppressImplicitAnyIndexErrors`
pmstss Jul 11, 2024
9d33fa4
fix: typing issues after typescript update
pmstss Jul 11, 2024
edd77a8
chore(eslint): remove invalid `private-abstract-method` and deprecate…
pmstss Jul 11, 2024
4528a9f
chore: add nx aux folders to gitignore
pmstss Jul 11, 2024
4052ae9
fix: violations due to updated eslint and plugins
pmstss Jul 11, 2024
1ddd7b8
chore: cleanup unused/legacy nx parts
pmstss Jul 11, 2024
532ff16
chore(test): updated typescript stricter typing fix
pmstss Jul 11, 2024
c1acf01
build(deps): minor and patch bumps
pmstss Jul 11, 2024
9acf4e8
chore: `@nx/dependency-checks` rule config
pmstss Jul 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 21 additions & 11 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,13 +1,18 @@
{
"root": true,
"ignorePatterns": ["**/*"],
"plugins": ["@nrwl/nx", "@typescript-eslint", "import", "jest"],
"plugins": ["@nx", "@typescript-eslint", "import", "jest"],
"extends": ["prettier", "eslint:recommended"],
"overrides": [
{
"files": "*.json",
"parser": "jsonc-eslint-parser",
"rules": {}
},
{
"files": ["*.ts", "*.tsx", "*.js", "*.jsx"],
"rules": {
"@nrwl/nx/enforce-module-boundaries": [
"@nx/enforce-module-boundaries": [
"error",
{
"enforceBuildableLibDependency": true,
Expand All @@ -25,7 +30,7 @@
{
"files": ["*.ts", "*.tsx"],
"extends": [
"plugin:@nrwl/nx/typescript",
"plugin:@nx/typescript",
"plugin:import/typescript",
"plugin:@typescript-eslint/recommended",
"plugin:@typescript-eslint/eslint-recommended"
Expand All @@ -38,7 +43,9 @@
"typescript": {}
}
},
"parserOptions": { "project": "./tsconfig.*?.json" },
"parserOptions": {
"project": "./tsconfig.*?.json"
},
"rules": {
"@typescript-eslint/explicit-member-accessibility": [
"error",
Expand Down Expand Up @@ -70,7 +77,6 @@
"private-static-method",
"public-abstract-method",
"protected-abstract-method",
"private-abstract-method",
"public-instance-method",
"protected-instance-method",
"private-instance-method"
Expand Down Expand Up @@ -99,10 +105,16 @@
"selector": "function",
"format": ["PascalCase", "camelCase"]
},
{ "selector": "variable", "format": ["camelCase", "UPPER_CASE", "PascalCase"], "leadingUnderscore": "forbid" },
{ "selector": "objectLiteralProperty",
{
"selector": "variable",
"format": ["camelCase", "UPPER_CASE", "PascalCase"],
"leadingUnderscore": "forbid"
},
{
"selector": "objectLiteralProperty",
"format": [],
"modifiers": ["requiresQuotes"] },
"modifiers": ["requiresQuotes"]
},
{
"selector": "method",
"format": ["camelCase", "PascalCase"],
Expand All @@ -113,7 +125,6 @@
"format": ["camelCase", "UPPER_CASE", "snake_case"],
"leadingUnderscore": "allow"
},
// https://github.com/typescript-eslint/typescript-eslint/issues/1510#issuecomment-580593245
{
"selector": "parameter",
"format": ["camelCase"],
Expand All @@ -129,7 +140,6 @@
],
"@typescript-eslint/default-param-last": "error",
"@typescript-eslint/consistent-type-assertions": "error",
"@typescript-eslint/no-duplicate-imports": "error",
"@typescript-eslint/no-non-null-assertion": "error",
"@typescript-eslint/unified-signatures": "error",
"@typescript-eslint/no-unnecessary-boolean-literal-compare": "error",
Expand Down Expand Up @@ -244,7 +254,7 @@
},
{
"files": ["*.js", "*.jsx"],
"extends": ["plugin:@nrwl/nx/javascript"],
"extends": ["plugin:@nx/javascript"],
"rules": {}
},
{
Expand Down
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,6 @@ Thumbs.db

# Config Files
.env

.nx/cache
.nx/workspace-data
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,5 @@
/node_modules
*-lock.json
*.lock

/.nx/cache
3 changes: 3 additions & 0 deletions .vscode/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"eslint.validate": ["json"]
}
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ $ npm run format -- --projects=${lib},${lib1}
Issue the following command to generate a new package:

```bash
$ nx generate @nrwl/node:lib ${lib} --importPath=@sectester/${lib}
$ nx generate @nx/node:lib ${lib} --importPath=@sectester/${lib}
```

> ⚡ It is important to have a clean git working directory before invoking a generator so that you can easily revert changes and re-invoke the generator with different inputs.
Expand Down
2 changes: 1 addition & 1 deletion jest.config.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const { getJestProjects } = require('@nrwl/jest');
const { getJestProjects } = require('@nx/jest');

export default {
projects: getJestProjects()
Expand Down
2 changes: 1 addition & 1 deletion jest.preset.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const nxPreset = require('@nrwl/jest/preset').default;
const nxPreset = require('@nx/jest/preset').default;

module.exports = {
...nxPreset,
Expand Down
39 changes: 26 additions & 13 deletions nx.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
{
"npmScope": "sectester",
"affected": {
"defaultBase": "master"
},
Expand All @@ -8,7 +7,7 @@
"libsDir": "packages"
},
"generators": {
"@nrwl/node:library": {
"@nx/node:library": {
"buildable": true,
"publishable": true,
"pascalCaseFiles": true,
Expand All @@ -25,22 +24,36 @@
"tsconfig.base.json": "*",
"nx.json": "*"
},
"tasksRunnerOptions": {
"default": {
"runner": "nx/tasks-runners/default",
"options": {
"cacheableOperations": ["build", "lint", "test", "e2e"],
"parallel": 1
}
}
},
"$schema": "./node_modules/nx/schemas/nx-schema.json",
"targetDefaults": {
"publish": {
"dependsOn": ["build"]
},
"build": {
"dependsOn": ["^build"]
"dependsOn": ["^build"],
"cache": true
},
"@nx/eslint:lint": {
"cache": true,
"inputs": [
"default",
"{workspaceRoot}/.eslintrc.json",
"{workspaceRoot}/tools/eslint-rules/**/*"
]
},
"@nx/jest:jest": {
"cache": true,
"inputs": ["default", "^default", "{workspaceRoot}/jest.preset.js"],
"options": {
"passWithNoTests": true
},
"configurations": {
"ci": {
"ci": true,
"codeCoverage": true
}
}
}
}
},
"parallel": 1
}
Loading
Loading