Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate and tidy examples #98

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Consolidate and tidy examples #98

merged 4 commits into from
Sep 24, 2024

Conversation

magland
Copy link
Collaborator

@magland magland commented Sep 20, 2024

#97 should be merged first

Tidy up the examples directory. Now it only contains four examples that are clearly labeled, corresponding to the four examples in the readme.

There is also a benchmark1.py example that compares write times between zarr, lindi, hdf5, and dat formats.

Delete LindiStagingStore functionality
Remove test_lindi_file.py unit test
@magland magland requested a review from rly September 20, 2024 11:43
@codecov-commenter
Copy link

codecov-commenter commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.13%. Comparing base (9183af9) to head (bdcd402).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   69.07%   67.13%   -1.95%     
==========================================
  Files          34       30       -4     
  Lines        3046     2796     -250     
==========================================
- Hits         2104     1877     -227     
+ Misses        942      919      -23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@magland magland merged commit 2b17402 into main Sep 24, 2024
6 checks passed
@magland magland deleted the tidy-examples branch September 24, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants