Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Add arguments block to main MatNWB api functions #619

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

ehennestad
Copy link
Collaborator

Motivation

  • Use argument blocks for better input validation of user-facing functions
  • Improve test coverage

How to test the behavior?

Show here how to reproduce the new behavior (can be a bug fix or a new feature)

Checklist

  • Have you ensured the PR description clearly describes the problem and solutions?
  • Have you checked to ensure that there aren't other open or previously closed Pull Requests for the same change?
  • If this PR fixes an issue, is the first line of the PR description fix #XX where XX is the issue number?

- Move some functions io.spec namespace
- Add validation functions in matnwb.common namespace
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

Attention: Patch coverage is 91.60000% with 21 lines in your changes missing coverage. Please review.

Project coverage is 92.06%. Comparing base (d970ef1) to head (a78a239).

Files with missing lines Patch % Lines
+file/fillValidators.m 46.66% 8 Missing ⚠️
+io/+spec/readEmbeddedSpecifications.m 85.18% 4 Missing ⚠️
+matnwb/+common/mustBeValidSchemaVersion.m 85.71% 2 Missing ⚠️
NwbFile.m 92.59% 2 Missing ⚠️
nwbRead.m 95.00% 2 Missing ⚠️
+io/+spec/+internal/readEmbeddedSpecLocation.m 90.00% 1 Missing ⚠️
generateCore.m 94.11% 1 Missing ⚠️
generateExtension.m 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #619      +/-   ##
==========================================
+ Coverage   90.80%   92.06%   +1.25%     
==========================================
  Files         107      114       +7     
  Lines        4774     4750      -24     
==========================================
+ Hits         4335     4373      +38     
+ Misses        439      377      -62     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant