Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize validation #1494

Closed
wants to merge 4 commits into from
Closed

Conversation

CodyCBakerPhD
Copy link
Collaborator

fix #1431

Motivation

WIP synchronizing the behavior of the CLI pynwb.validate function with the library-imported one, namely for the purposes of validating against cached namespaces (but also just to have identical behavior between library and CLI use cases).

How to test the behavior?

Need to...

[ ] - Thoroughly test that the CLI usage behaves as it used to
[ ] - The cached namespace feature is indeed available to the new library method as well
[ ] - Ensure there is no break in back-combability when using the previous methods

Checklist

  • Did you update CHANGELOG.md with your changes?
  • Have you checked our Contributing document?
  • Have you ensured the PR clearly describes the problem and the solution?
  • Is your contribution compliant with our coding style? This can be checked running flake8 from the source directory.
  • Have you checked to ensure that there aren't other open Pull Requests for the same change? - a splinter/extension of enh/getcachednamespaces
  • Have you included the relevant issue number using "Fix #XXX" notation where XXX is the issue number? By including "Fix #XXX" you allow GitHub to close issue #XXX when the PR is merged.

@CodyCBakerPhD CodyCBakerPhD changed the title Generalize validation 1 Generalize validation Jul 4, 2022
@CodyCBakerPhD CodyCBakerPhD self-assigned this Jul 7, 2022
@rly
Copy link
Contributor

rly commented Jul 8, 2022

Related to #1432.

@CodyCBakerPhD can you adjust this PR to branch off of dev? I have some thoughts on the modularize PR #1493. I'd like to get this PR sooner.

@CodyCBakerPhD CodyCBakerPhD mentioned this pull request Jul 18, 2022
9 tasks
@CodyCBakerPhD
Copy link
Collaborator Author

Replaced by #1511

@CodyCBakerPhD CodyCBakerPhD deleted the generalize_validation_1 branch July 18, 2022 18:04
@oruebel oruebel mentioned this pull request Nov 1, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants