Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

공통 Compose 컴포넌트 구조 개선 #65

Merged
merged 6 commits into from
Oct 7, 2024
Merged

공통 Compose 컴포넌트 구조 개선 #65

merged 6 commits into from
Oct 7, 2024

Conversation

eshc123
Copy link
Member

@eshc123 eshc123 commented Oct 5, 2024

주요 내용

재사용 Component 모듈 및 패키지 이동

  1. 전역적으로 사용 가능한 Component는 core:designsystem 모듈의 component 패키지(Button, Chip, Tabs, TopAppBar, TextFiled 등)
  2. 몇몇의 특정 화면에서만 사용되는 Component는 core:ui 모듈의 component 패키지
  3. 하나의 특정 화면에서만 사용되는 Component는 사용되는 feature 모듈의 component 패키지 혹은 사용된 파일 내(ex : feature:board의 component 패키지에서의 Block)

Image -> StableImage 사용

  • Recomposition 최적화를 위해 Image를 사용하는 부분을 StableImage로 변경

참고 : https://tech.wonderwall.kr/articles/recomposition/

@eshc123 eshc123 requested a review from bywindow October 5, 2024 03:48
@eshc123 eshc123 self-assigned this Oct 5, 2024
bywindow
bywindow approved these changes Oct 7, 2024
View reviewed changes
Copy link
Collaborator

@bywindow bywindow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

크으👍👍👍

@eshc123 eshc123 merged commit 19bb415 into dev Oct 7, 2024
1 check passed
@eshc123 eshc123 deleted the refactor/component branch October 7, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bywindow bywindow bywindow approved these changes

Assignees

@eshc123 eshc123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshc123 @bywindow