Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GamePath FileTree support #570

Merged
merged 5 commits into from
Aug 24, 2023
Merged

GamePath FileTree support #570

merged 5 commits into from
Aug 24, 2023

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Aug 23, 2023

closes #553

Adds support for GamePath based FileTrees (FileTreeNode<GamePath>).

  • Made game path extend IPath<GamePath> so the file tree can use it.
  • Implemented IPath<> interface methods
  • Added tests for new methods
  • Added simple test for FileTreeNode<GamePath> (Paths library has more extensive testing already).

@Al12rs
Copy link
Contributor Author

Al12rs commented Aug 23, 2023

Follow up to Nexus-Mods/NexusMods.Paths#11

@Al12rs Al12rs self-assigned this Aug 23, 2023
@Al12rs Al12rs requested a review from a team August 23, 2023 14:19
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #570 (410ef82) into main (42aeda6) will increase coverage by 67.54%.
Report is 5 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           main     #570       +/-   ##
=========================================
+ Coverage      0   67.54%   +67.54%     
=========================================
  Files         0      602      +602     
  Lines         0    16226    +16226     
  Branches      0     1105     +1105     
=========================================
+ Hits          0    10960    +10960     
- Misses        0     4976     +4976     
- Partials      0      290      +290     
Flag Coverage Δ
Linux 67.54% <100.00%> (?)
clean_environment_tests 67.54% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/NexusMods.DataModel/Games/GamePath.cs 94.73% <100.00%> (ø)

... and 601 files with indirect coverage changes

@halgari halgari merged commit f5a269a into main Aug 24, 2023
5 checks passed
@halgari halgari deleted the gamepath-filetree-support branch August 24, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Add a file tree abstraction for mod installers (and other parts of the app)
2 participants