Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HTTPs based submodule paths #17

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Use HTTPs based submodule paths #17

merged 2 commits into from
Sep 5, 2023

Conversation

Al12rs
Copy link
Contributor

@Al12rs Al12rs commented Aug 31, 2023

git@ based reference require user authentication during clone, which isn't useful for an open source project.

fixes Nexus-Mods/NexusMods.App#590

…thentication during clone, which isn't useful for an open source project.
@Al12rs Al12rs requested a review from a team August 31, 2023 09:55
Copy link
Member

@Sewer56 Sewer56 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did this change in another repo before so LGTM

@Al12rs Al12rs self-assigned this Aug 31, 2023
@Al12rs
Copy link
Contributor Author

Al12rs commented Aug 31, 2023

The tests seem to be stuck on waiting, I can't seem to merge.

@Sewer56
Copy link
Member

Sewer56 commented Aug 31, 2023

Well, this is weird...

@Al12rs
Copy link
Contributor Author

Al12rs commented Aug 31, 2023

@halgari any clues what might be happening here? I see the same thing on the bot submodule update PR

@erri120
Copy link
Member

erri120 commented Sep 4, 2023

The tests are marked as "expected", however, they don't run because none of the source files have been updated.

@halgari halgari merged commit 87c3197 into main Sep 5, 2023
1 check passed
@halgari halgari deleted the submodule_cloning branch September 5, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Can't clone Paths library without an Authentication key due to git@ based submodule urls
4 participants