Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

identity: implemented google id flow #127

Merged
merged 1 commit into from
Sep 24, 2024
Merged

identity: implemented google id flow #127

merged 1 commit into from
Sep 24, 2024

Conversation

TheButlah
Copy link
Contributor

No description provided.

@TheButlah TheButlah force-pushed the thebutlah/google-oauth branch 5 times, most recently from 1aa1ad7 to 6fc82e8 Compare September 24, 2024 05:11
@TheButlah TheButlah marked this pull request as ready for review September 24, 2024 05:19
@TheButlah TheButlah force-pushed the thebutlah/google-oauth branch 2 times, most recently from 5419141 to e235e06 Compare September 24, 2024 06:07
lyuma
lyuma approved these changes Sep 24, 2024
View reviewed changes
Copy link

@lyuma lyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is really understandable and seems good

JWT validation is mostly handled by jsonwebtoken, and most of this code handles fetching the official google keystore (JWKS) and determining which data to pass to the jsonwebtoken library.

@TheButlah TheButlah merged commit 61f701f into main Sep 24, 2024
4 checks passed
@TheButlah TheButlah deleted the thebutlah/google-oauth branch September 24, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyuma lyuma lyuma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TheButlah @lyuma