Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented more of the DidKey struct #94

Merged
merged 2 commits into from
May 14, 2024
Merged

Implemented more of the DidKey struct #94

merged 2 commits into from
May 14, 2024

Conversation

TheButlah
Copy link
Contributor

No description provided.

@TheButlah TheButlah changed the title Added display impls and started filling out DidKey struct Implemented more of the DidKey struct May 14, 2024
@TheButlah TheButlah requested a review from MalekiRe May 14, 2024 09:20
@TheButlah TheButlah marked this pull request as ready for review May 14, 2024 09:20
Copy link
Contributor

@MalekiRe MalekiRe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TheButlah TheButlah merged commit b8ab348 into main May 14, 2024
3 checks passed
@TheButlah TheButlah deleted the thebutlah/did-key branch May 14, 2024 09:59
TheButlah added a commit that referenced this pull request May 18, 2024
Previously in #94 I implemented the multibase decode of the url. This PR
adds the ability to read that decoded byte slice and parse out the
keytype from it.

This required implementing the varint encoding scheme described in the
multicodec spec.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants