-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: node stability improvements & design fixes #663
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
corn-potage
commented
Sep 16, 2024
•
edited
Loading
edited
- Added starting and stopping states to button, disabled states to stop user from interrupting
- Replaced advanced options with show other node types on add node screen
- Added update modal, added simple modal mode
- Changed OP static ports to dynamic
- Refactored start and stop node code
- Modified certain buttons to have different cursors
- Decreased shadow on popup on chart
- Changed checkbox to match spec
- Info icon changed to transparent black
- Refactored sync status (getStatusObject handles multiple states)
- Added sync status and sync progress to client cards
- Added % support and minute/seconds display on ProgressBar
- Fixed client card heights
- Moved controller info under dev mode
- Fixed node version display
- 1 client screen now shows 100% width
- Added dark mode art to onboarding flow
- Link color fixed for dark mode
- Added tab deeplink support (notifications preference), and not display tabs if only 1 item
- Fixed sidebar background color
- Notifications number on sidebar is now cleared when all notifications are marked as read
- ThemeContext added to allow us to retrieve theme status everywhere in the app
- Major refactoring, modifications on NodePackageScreen, NodeScreen, SidebarNodeItemWrapper to optimize, align and display same status
- Support external node check and compare CL execution payload and EL for more robust isSyncing status
- Check and stop node package if all nodes are stopped manually from NodeScreen
- Change Sync sub-status of In Progress... to Catching up if all nodes have finished synchronizing at least once
- RpcExecuteTranslation modified to support specific node spec, and retrieve needed data for different node types
- Simplified front-end polling to rely on node/node package 'running' status (@jgresham, need confirmation if this is ok)
- If user clicks area outside of modal, it closes modal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.