fix last commit

NickHugi · Feb 24, 2024 · 9cf503b · 9cf503b
1 parent 775cb0d
commit 9cf503b
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 30 deletions.
diff --git a/compile/compile_batchpatcher.ps1 b/compile/compile_batchpatcher.ps1
@@ -45,7 +45,7 @@ $pyInstallerArgs = @{
         'pykotor-gl'
     )
     'clean' = $true
-    'console' = $true
+    'noconsole' = $true  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x  https://pyinstaller.org/en/stable/usage.html#cmdoption-w
     'onefile' = $true
     'noconfirm' = $true
     'name' = 'K_BatchPatcher'
@@ -75,11 +75,6 @@ $pyInstallerArgs = $pyInstallerArgs.GetEnumerator() | ForEach-Object {
     }
 }
 
-# Ensure .app is created on Mac OS X:
-if ((Get-OS) -eq "Mac") {  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x
-    $pyInstallerArgs += "--windowed"
-}
-
 # Add PYTHONPATH paths as arguments
 $env:PYTHONPATH -split ';' | ForEach-Object {
     $pyInstallerArgs += "--path=$_"

diff --git a/compile/compile_gui_duplicator.ps1 b/compile/compile_gui_duplicator.ps1
@@ -79,7 +79,7 @@ $pyInstallerArgs = @{
         'beautifulsoup4'
     )
     'clean' = $true
-    'console' = $true
+    'console' = $true  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x  https://pyinstaller.org/en/stable/usage.html#cmdoption-w
     'onefile' = $true
     'noconfirm' = $true
     'name' = "GuiDuplicator"
@@ -109,11 +109,6 @@ $pyInstallerArgs = $pyInstallerArgs.GetEnumerator() | ForEach-Object {
     }
 }
 
-# Ensure .app is created on Mac OS X:
-if ((Get-OS) -eq "Mac") {  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x
-    $pyInstallerArgs += "--windowed"
-}
-
 # Add PYTHONPATH paths as arguments
 $env:PYTHONPATH -split ';' | ForEach-Object {
     $pyInstallerArgs += "--path=$_"

diff --git a/compile/compile_holopatcher.ps1 b/compile/compile_holopatcher.ps1
@@ -74,7 +74,7 @@ $pyInstallerArgs = @{
         'beautifulsoup4'
     )
     'clean' = $true
-    'noconsole' = $true
+    'noconsole' = $true  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x  https://pyinstaller.org/en/stable/usage.html#cmdoption-w
     'onefile' = $true
     'noconfirm' = $true
     'distpath' = ($rootPath + $pathSep + "dist")
@@ -105,11 +105,6 @@ $pyInstallerArgs = $pyInstallerArgs.GetEnumerator() | ForEach-Object {
     }
 }
 
-# Ensure .app is created on Mac OS X:
-if ((Get-OS) -eq "Mac") {  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x
-    $pyInstallerArgs += "--windowed"
-}
-
 # Add PYTHONPATH paths as arguments
 $env:PYTHONPATH -split ';' | ForEach-Object {
     $pyInstallerArgs += "--path=$_"

diff --git a/compile/compile_kotordiff.ps1 b/compile/compile_kotordiff.ps1
@@ -79,7 +79,7 @@ $pyInstallerArgs = @{
         'beautifulsoup4'
     )
     'clean' = $true
-    'console' = $true
+    'console' = $true  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x  https://pyinstaller.org/en/stable/usage.html#cmdoption-w
     'onefile' = $true
     'noconfirm' = $true
     'name' = "KotorDiff"
@@ -109,11 +109,6 @@ $pyInstallerArgs = $pyInstallerArgs.GetEnumerator() | ForEach-Object {
     }
 }
 
-# Ensure .app is created on Mac OS X:
-if ((Get-OS) -eq "Mac") {  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x
-    $pyInstallerArgs += "--windowed"
-}
-
 # Add PYTHONPATH paths as arguments
 $env:PYTHONPATH -split ';' | ForEach-Object {
     $pyInstallerArgs += "--path=$_"

diff --git a/compile/compile_toolset.ps1 b/compile/compile_toolset.ps1
@@ -40,7 +40,7 @@ $pyInstallerArgs = @{
         'torch'
     )
     'clean' = $true
-    'console' = $true
+    'noconsole' = $true  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x  https://pyinstaller.org/en/stable/usage.html#cmdoption-w
     'onefile' = $true
     'noconfirm' = $true
     'name' = "HolocronToolset"
@@ -71,11 +71,6 @@ $pyInstallerArgs = $pyInstallerArgs.GetEnumerator() | ForEach-Object {
     }
 }
 
-# Ensure .app is created on Mac OS X:
-if ((Get-OS) -eq "Mac") {  # https://github.com/pyinstaller/pyinstaller/wiki/FAQ#mac-os-x
-    $pyInstallerArgs += "--windowed"
-}
-
 # Add PYTHONPATH paths as arguments
 $env:PYTHONPATH -split ';' | ForEach-Object {
     $pyInstallerArgs += "--path=$_"