Zib2024 initial zibs #301
Open
Zib2024 initial zibs #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieter-edelman-nictiz
requested changes
Nov 5, 2024
| deviating way, but it should normally not be required. --> | ||
|
|
||
| <!-- If so required, an xsl:when condition can be added for templates that need to be called in some deviating way, but it should normally not be required. --> | ||
| <xsl:when test="$localName = 'contactpersoon'"> |
There was a problem hiding this comment.
It seems to me that this violates the mapping guidelines. The parameter should be called "subject", and this explicit test should not be needed.
There was a problem hiding this comment.
I don't see how we can remove these explicit tests, since the mode of apply-templates cannot be variable (likewise for the name of call-template), and without these the conversion crashes.
ada_2_fhir-r4/zibs2024/payload/0.1-beta.1/nl-core-ContactPerson.xsl
Outdated
Show resolved
Hide resolved
ada_2_fhir-r4/zibs2024/payload/0.1-beta.1/nl-core-ContactPerson.xsl
Outdated
Show resolved
Hide resolved
ada_2_fhir-r4/zibs2024/payload/0.1-beta.1/nl-core-AddressInformation.xsl
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.