Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add QA check on release notes #12

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

pieter-edelman-nictiz
Copy link
Member

No description provided.

Copy link

@ArdonToonstra ArdonToonstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woe, nice work Pieter! You are going for it.

  • Would it be possible that it spits out all the errors at once instead of one by one?
  • Could it give a warning if nothing is found in the last column (the link)? Currently it gives an error if you don't add the last ; but it accepts an empty spot
  • Also, the first line does not have to follow the [path] ; [category] ; [remark] ; [link] format because it can state something generic like: new profile not present in 2020 release or somekind.

For example, I have the following for AnatomicalLocation that throws an error for zib-AnatomicalLocation-BodyStructure profile:

## AnatomicalLocation 
### zib-AnatomicalLocation
* `CodeableConcept` ; textual ; Refined guidance for Location and Laterality ; ZIBFHIR-113
* `.extension:bodyStructureReference` ; extension ; Replaced ExtAnatomicalLocationLaterality with BodyStructureReference for Laterality ; ZIBFHIR-113
* `.extension:bodyStructureReference` ; mapping ; Moved mapping of Laterality to `BodyStructure.locationQualifier` ; ZIBFHIR-113

### zib-AnatomicalLocation-BodyStructure
* New profile that maps Laterality to a native FHIR element inside the BodyStructure resource instead of a custom extension (ZIBFHIR-113).

@pieter-edelman-nictiz
Copy link
Member Author

Woe, nice work Pieter! You are going for it.

* Would it be possible that it spits out all the errors at once instead of one by one?

Possible yes, but a bit too much work (for now)

* Could it give a warning if nothing is found in the last column (the link)? Currently it gives an error if you don't add the last ;  but it accepts an empty spot

It throws an error now, and also throws an error if the issue keys are not formatted correctly.

* Also, the first line does not have to follow the [path] ; [category] ; [remark] ; [link] format because it can state something generic like: new profile not present in 2020 release or somekind.

Fixed this and added the option to have issue keys here as well. It doesn't check if this is the first line though.

Copy link

@ArdonToonstra ArdonToonstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements Pieter. Let's go!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants