-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V2 #8
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine from a typescript perspective. Some might argue that main.ts or marshalling.ts could be renamed to typings.ts
because the content but the file name choice isn't important so meh
type definitions look good to me 👍 10/10 would approve
@calebjeffrey Thank you 😄 Do you know if there is there a way to control the declaration outputs? The only option I can find is I'd like to keep the types in their respective source files, rather than extracting them into a Edit: I just realized you aren't talking about the output/built files. Ignore the above.
|
Complete re-write using Typescript and the AWS SDK v3 DynamoDB Client. Attempts to retain the same API, but the result is no longer a modified dynamo client, it's a butter client that only exposes the "document client" methods.