Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolves #181 Add AssertionError #184

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

chrimaho
Copy link

@chrimaho chrimaho commented Apr 5, 2021

This PR resolves #181.

It adds a second loop to the parseExceptions() function, which searches for a different pattern (/(?<!#.*)assert\s+/), and adds each to the list of exceptions.

The assert loop is run first, because assert's are usually at the beginning of functions, while raise's are usually later.

@NilsJPWerner
Copy link
Owner

NilsJPWerner commented Feb 8, 2022

Hi sorry for the very very late reply. This would be a good addition. Could you add tests to this pr? Also can you rebase master to get the github actions to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add assert to Exceptions
2 participants