Upgrade to Spring Boot 3.2.2, Kotlin 1.9.22, Gradle 8.5 + Etc. #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This upgrade includes some changes of the test codes which corresponds to significant changes that have been made in Spring Boot 3.2. mybatis project encountered the same issue, so its pr helped a lot making this upgrade done. The brief explanations are: 1. As of Spring Framework 6.1, we can't pass the value of `factoryBeanObjectType` as `String` to `BeanDefinition`. 2. `BeanFactory.getBean()` in `BeanFactoryExtensions` has been changed. Good thing is, the changes above don't seem to affact the implementations. All we need to do is to correct the test code. For the details, please check the references below. ## Reference * mybatis pr: mybatis/spring#865 * as-is 1: https://github.com/spring-projects/spring-framework/blob/66f4509c2c7a1ad0255ed84f9e5efb340bd0b470/spring-beans/src/main/java/org/springframework/beans/factory/support/FactoryBeanRegistrySupport.java#L74-L83 * to-be 1: https://github.com/spring-projects/spring-framework/blob/00577ed80acfc22104b41d6a631f433a3fa7e6af/spring-beans/src/main/java/org/springframework/beans/factory/support/FactoryBeanRegistrySupport.java#L74-L87 * as-is 2: https://github.com/spring-projects/spring-framework/blob/66f4509c2c7a1ad0255ed84f9e5efb340bd0b470/spring-beans/src/main/kotlin/org/springframework/beans/factory/BeanFactoryExtensions.kt#L28 * to-be 2: https://github.com/spring-projects/spring-framework/blob/00577ed80acfc22104b41d6a631f433a3fa7e6af/spring-beans/src/main/kotlin/org/springframework/beans/factory/BeanFactoryExtensions.kt#L29-L30
This commit deals with: * Unnecessary import and redundant dependency * More kotlin-like code style * Refactoring advice from Intellij 2023.3.3 * More accurate KDoc expression * Simplifying duplicate message
|
If this is merged, I'll solve conflicts that are expected to happen on #112 with responsibility. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just did what it supposed to be done.
Making an upgrade to Spring Boot 3.2.2 was a lot more than just replacing its version number in
build.gradle.kts.You can check the details in 8345211.
Hope this pr is approved.
Also please check #110.
Thank you.