Merge pull request #625 from Nitrokey/fix-admin-auth

Fix admin auth
Nitrokey · Feb 25, 2025 · 2828c1d · 2828c1d
2 parents 65a0cee + 0fcdfdd
commit 2828c1d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/pynitrokey/VERSION b/pynitrokey/VERSION
@@ -1 +1 @@
-0.7.3
+0.7.4
diff --git a/pynitrokey/nk3/piv_app.py b/pynitrokey/nk3/piv_app.py
@@ -210,9 +210,9 @@ def authenticate_admin(self, admin_key: bytes) -> None:
 
         our_challenge = os.urandom(expected_len)
         cipher = Cipher(algorithm, mode=modes.ECB())
-        encryptor = cipher.encryptor()
         decryptor = cipher.decryptor()
-        response = encryptor.update(challenge) + encryptor.finalize()
+        response = decryptor.update(challenge) + decryptor.finalize()
+        decryptor = cipher.decryptor()
         our_challenge_encrypted = decryptor.update(our_challenge) + decryptor.finalize()
         response_body = Tlv.build(
             [(0x7C, Tlv.build([(0x80, response), (0x81, our_challenge_encrypted)]))]