Nethsm: fix add-key command #627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sosthene-nitrokey
requested review from
daringer,
mmerklinger and
robin-nitrokey
sosthene-nitrokey
force-pushed
the
nethsm-add-key-mechanisms
branch
from
9be7fdc to
a81b6f9
Compare
The mechanism list requires ending with an empty string, but click did not accept that
sosthene-nitrokey
force-pushed
the
nethsm-add-key-mechanisms
branch
from
a81b6f9 to
9deeec6
Compare
|
I think we should merge this as part of release 0.7.4 |
daringer
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mechanism list requires ending with an empty string, but click did not accept that
Changes
Checklist
Make sure to run
make checkandmake fixbefore creating a PR, otherwise the CI will fail.